-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better-sqlite3 works under node20 but gives error under deno #1205
Comments
Looks like I'm far from the first person to hit this but it appears to still not work as of deno 1.44.2 |
@JoshuaWise do you want to support different runtimes, like bun and deno? |
marvinhagemeister
pushed a commit
to denoland/deno
that referenced
this issue
Jul 26, 2024
Adds support for `npm:bindings` and `npm:callsites` packages because of changes in denoland/deno_core#838. This `deno_core` bump causes us to stop prepending `file://` scheme for locations in stack traces that are for local files. Fixes #24462 , fixes #22671 , fixes #15717 , fixes #19130 , fixes WiseLibs/better-sqlite3#1205 , fixes WiseLibs/better-sqlite3#1034 , fixes #20936 --------- Co-authored-by: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com>
dsherret
pushed a commit
to denoland/deno
that referenced
this issue
Jul 26, 2024
Adds support for `npm:bindings` and `npm:callsites` packages because of changes in denoland/deno_core#838. This `deno_core` bump causes us to stop prepending `file://` scheme for locations in stack traces that are for local files. Fixes #24462 , fixes #22671 , fixes #15717 , fixes #19130 , fixes WiseLibs/better-sqlite3#1205 , fixes WiseLibs/better-sqlite3#1034 , fixes #20936 --------- Co-authored-by: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure if this is a better-sqlite3 issue or a deno issue but I thought it might be of interest and of course I'd be grateful for help.
With a minimal node20 test project this
index.mjs
run withnode index.mjs
afternode install better-sqlite3
works as expected:while this near-equivalent
test_better_sqlite3.js
file run withdeno run -A test_better_sqlite3.js
fails (errors below):The error output is:
Ideas?
The text was updated successfully, but these errors were encountered: