Use node bullseye to build arm images #1216
Conversation
There was a problem hiding this comment.
Excellent, thank you!
I looked into using buster instead of bullseye, but LTS for buster ended on June 30, 2024.
A gotcha that might bite us in the future due to this: GHA tests may pass with recent Ubuntu docker images, but running with prebuilds may have some spurious errors due to some GCC change between v2.31 and current. Mentioning @JoshuaWise for visibility.
Also: we should consider replacing the linux prebuild step with something akin to the prebuild-linux-arm step that uses docker (so we can get arbitrary glibc prebuilds for amd64 as well).
|
Omg, arbitrary glibc prebuilds would be fantastic. 2.28 seems very old now, but in particular the Ubuntu Extended Security Maintenance program (which is free for individuals) supports Ubuntu 18.04 until 2028, so a significant number of folks are going to be on 18.04 for a while. Seeing as using an older version of glibc isn't a problem (just using a newer one), this would be fantastic. @mceachen Would you be open to a PR that set up an environment with glibc 2.28+ as the compile target using the prebuild step you suggest above? |
|
@rathboma if the test suite can validate the prebuild works (so we'd use a docker image just like what this PR does), I don't see the downside to supporting Ubuntu 18 until it's really EOL (unless somehow it breaks newer more common builds, but I don't see that happening). |
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [better-sqlite3](https://togithub.com/WiseLibs/better-sqlite3) | [`11.1.1` -> `11.1.2`](https://renovatebot.com/diffs/npm/better-sqlite3/11.1.1/11.1.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>WiseLibs/better-sqlite3 (better-sqlite3)</summary> ### [`v11.1.2`](https://togithub.com/WiseLibs/better-sqlite3/releases/tag/v11.1.2) [Compare Source](https://togithub.com/WiseLibs/better-sqlite3/compare/v11.1.1...v11.1.2) #### What's Changed - Use node bullseye to build arm images by [@​viceice](https://togithub.com/viceice) in [https://github.com/WiseLibs/better-sqlite3/pull/1216](https://togithub.com/WiseLibs/better-sqlite3/pull/1216) #### New Contributors - [@​viceice](https://togithub.com/viceice) made their first contribution in [https://github.com/WiseLibs/better-sqlite3/pull/1216](https://togithub.com/WiseLibs/better-sqlite3/pull/1216) **Full Changelog**: WiseLibs/better-sqlite3@v11.1.1...v11.1.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cap-js/cds-dbs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This will downgrade the used GLIBC to v2.31, so it's again compatibe with ubuntu 20.04.