Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 prebuilds for macOS #859

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

qier222
Copy link
Contributor

@qier222 qier222 commented Aug 5, 2022

@qier222 qier222 requested review from JoshuaWise and a team as code owners August 5, 2022 15:48
@qier222 qier222 force-pushed the feat/macos-arm64-prebuild branch from c1de1af to f9eecfb Compare August 6, 2022 08:25
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This delta assumes the github actions runner arch will be intel--that may not be a safe default, given how you can't even buy intel macos boxes anymore.

Is there a nicer way to do this? Use qemu like we do for alpine? Perhaps make line 73 specific to linux, and make 2 run lines for macos with --arch?

@evanpurkhiser
Copy link

This delta assumes the github actions runner arch will be intel--that may not be a safe default, given how you can't even buy intel macos boxes anymore.

Are we worried about the GHA worker being swapped under our feet? I would expect GitHub to give ample notice if they change their macOS workers.

Just my 2c but seems like it would be better to merge this and make everyone in #769 happy than to try and get the workflow highly-future-proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants