forked from jgm/lunamark
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly parse paragraphs with trailing spaces #347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Witiko
force-pushed
the
fix/paragraphs-with-trailing-spaces
branch
2 times, most recently
from
September 6, 2023 11:50
88072da
to
67cd215
Compare
Witiko
force-pushed
the
fix/paragraphs-with-trailing-spaces
branch
from
September 6, 2023 11:58
67cd215
to
418c94b
Compare
This reverts commit 1ae1639.
Witiko
force-pushed
the
fix/paragraphs-with-trailing-spaces
branch
3 times, most recently
from
September 8, 2023 08:22
f4e57df
to
8669d04
Compare
I created a python file import json
import sys
for example in json.load(sys.stdin):
if ' \n' in example['markdown'] or '\t\n' in example['markdown'] or example['markdown'].endswith(' ') or example['markdown'].endswith('\t'):
print(example['example']) Then, I ran the following commands, finding 34 CommonMark examples with trailing tabs and spaces:
|
Witiko
force-pushed
the
fix/paragraphs-with-trailing-spaces
branch
4 times, most recently
from
September 8, 2023 10:31
9399818
to
32c3326
Compare
Witiko
force-pushed
the
fix/paragraphs-with-trailing-spaces
branch
from
September 8, 2023 11:02
32c3326
to
b8538d3
Compare
…inal issue" This reverts commit b8538d3.
Witiko
added
automerge
This pull request will be automatically merged after continuous integration has succeeded
and removed
automerge
This pull request will be automatically merged after continuous integration has succeeded
labels
Sep 8, 2023
Witiko
force-pushed
the
fix/paragraphs-with-trailing-spaces
branch
from
September 8, 2023 17:10
52ccf8b
to
b14167f
Compare
Witiko
force-pushed
the
fix/paragraphs-with-trailing-spaces
branch
from
September 8, 2023 22:21
b14167f
to
e0d76e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345 and continues https://github.com/danopolan/istqb_latex/pull/77.
Tasks
example.md
from The parser does not parse the full ISTQB example document #345 (comment) by fixing a regression introduced by Allow users to specify logical paragraphs by the number of blank lines between blocks #306.markdown/tests/templates/context-mkiv/verbatim/body.tex.m4
Lines 7 to 8 in c1af406
hard-line-breaks.test
, as described in The parser does not parse the full ISTQB example document #345 (comment).CHANGES.md
.Nice to haves
verbatim
template.title
,author
, anddate
to YAML blocks. Display these fields in addition to the name of a testfile intest.py
.