Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows unicode paths #216

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Conversation

zebrys
Copy link
Contributor

@zebrys zebrys commented Sep 22, 2020

Fix the issue #200 (on Windows).

@evanmiller
Copy link
Contributor

Do we need portable_main applied to the extract_metadata CLI tool also?

@zebrys
Copy link
Contributor Author

zebrys commented Sep 23, 2020

Do we need portable_main applied to the extract_metadata CLI tool also?

@evanmiller Are you talking about the replacement of main by portable_main in src/bin/extract_metadata.c? This is already the case.
Overall, all programs that take possible unicode parameters in input (eg. filenames) should use portable_main (only readstat and extract_metadata seems to need that I guess).

@evanmiller
Copy link
Contributor

Ah yes I was reading the patch too quickly. I will merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants