Skip to content
This repository has been archived by the owner on May 22, 2022. It is now read-only.

Can't translate on/off keys #6

Closed
Sikatsu opened this issue Aug 30, 2021 · 7 comments
Closed

Can't translate on/off keys #6

Sikatsu opened this issue Aug 30, 2021 · 7 comments
Labels
bug Something isn't working P3: Minor For Minor Bugs that do not affect general usage P5: Tested by Author - FIXED Tested by Issue Author - Fix Works
Milestone
ArmorStandEditor:...

Comments

@Sikatsu
Copy link

Sikatsu commented Aug 30, 2021 •
edited
Loading

Expected behavior

Being able to translate the on/off keys for gravity.

Observed/Actual behavior

image
image

image
@Sikatsu Sikatsu added the P1: To Be Tested Needs to be Tested label Aug 30, 2021
@Wolfieheart Wolfieheart added the bug Something isn't working label Aug 30, 2021
@Wolfieheart
Copy link
Owner

Initial Investigation is that it is related to: https://github.com/Wolfst0rm/ArmorStandEditor/blob/master/src/main/java/io/github/rypofalem/armorstandeditor/PlayerEditor.java#L350

Actually I am 100% sure on that, but going to have to debug it a bit which wont happen til this weekend probably.

@Sikatsu
Copy link
Author

Sikatsu commented Aug 31, 2021

Yeah that seems to be the reason why!

@Wolfieheart Wolfieheart added P2: Able to Reproduce Has been Tested and Able to Reproduce P3: Minor For Minor Bugs that do not affect general usage P3: Ready for Testing New Feature Implemented and Ready for Testing WIP Currently being worked on and removed P1: To Be Tested Needs to be Tested labels Sep 4, 2021
@Wolfieheart
Copy link
Owner

Wolfieheart commented Sep 4, 2021 •
edited
Loading

Will be commiting a review of this soon. Might have made it easier and changed the on/off keys to simple True/False but have the messages be on and off. Was the easiest way to fix this.

Wolfieheart added a commit to Wolfieheart/ArmorStandEditor that referenced this issue Sep 4, 2021
@Wolfieheart
[CORE] Fix for Wolfieheart/ArmorStandEditor-Issues#6: Translation of …
8f4e998 
…Off and On Keys in ToggleGravity no longer works.

Updated nl_NL to include new Strings. Will move over the other Languages shortly.

Signed-off-by: Wolfstorm <xMakeItRain94@gmail.com>
@Wolfieheart Wolfieheart removed P2: Able to Reproduce Has been Tested and Able to Reproduce WIP Currently being worked on labels Sep 4, 2021
Wolfieheart added a commit to Wolfieheart/ArmorStandEditor that referenced this issue Sep 4, 2021
@Wolfieheart
[CI-SKIP] Fix Language Files to reflect changes related to Wolfiehear…
301387b 
…t/ArmorStandEditor-Issues#6

Signed-off-by: Wolfstorm <xMakeItRain94@gmail.com>
@Sikatsu
Copy link
Author

Sikatsu commented Sep 5, 2021 •
edited
Loading

Awesome, thank you! If theres a build out regarding this or the item frames i'll test it out. 😄

@Wolfieheart
Copy link
Owner

There should already be a test build available. You can find it on: https://github.com/Wolfst0rm/ArmorStandEditor/suites/3683823741/artifacts/89742223

@Wolfieheart Wolfieheart added P4: Awaiting Retesting from Author Fixed, but needs testing from Issue Author before closing and removed P3: Ready for Testing New Feature Implemented and Ready for Testing labels Sep 7, 2021
@Sikatsu
Copy link
Author

Sikatsu commented Sep 8, 2021

This is now solved and can be closed, thank you! ^^

@Wolfieheart Wolfieheart added P5: Tested by Author - FIXED Tested by Issue Author - Fix Works and removed P4: Awaiting Retesting from Author Fixed, but needs testing from Issue Author before closing labels Sep 8, 2021
@Wolfieheart
Copy link
Owner

Fixed as of: Wolfieheart/ArmorStandEditor@8f4e998

JLyne pushed a commit to JLyne/ArmorStandEditor that referenced this issue Jan 28, 2022
@Wolfieheart @JLyne
[CORE] Fix for Wolfieheart/ArmorStandEditor-Issues#6: Translation of …
25a1035 
…Off and On Keys in ToggleGravity no longer works.

Updated nl_NL to include new Strings. Will move over the other Languages shortly.

Signed-off-by: Wolfstorm <xMakeItRain94@gmail.com>
JLyne pushed a commit to JLyne/ArmorStandEditor that referenced this issue Jan 28, 2022
@Wolfieheart @JLyne
[CI-SKIP] Fix Language Files to reflect changes related to Wolfiehear…
e69fb6f 
…t/ArmorStandEditor-Issues#6

Signed-off-by: Wolfstorm <xMakeItRain94@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working P3: Minor For Minor Bugs that do not affect general usage P5: Tested by Author - FIXED Tested by Issue Author - Fix Works
Projects
None yet
Milestone
ArmorStandEditor: Future (>1.18)
Development

No branches or pull requests
2 participants
@Sikatsu @Wolfieheart