Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix macOS build by working around bogus SDK detection #95

Merged
merged 1 commit into from
May 9, 2023

Conversation

akien-mga
Copy link
Collaborator

For whatever reason CMake seems to infer "12.6" as SDK version, because the GitHub Action macOS runner is based on macOS 12.6. But that number doesn't match the SDK version, which should be 13.1 here.

This seems to be a long running issue with GitHub Actions' macOS runner: actions/runner-images#2211

Though I can't tell if it's a CMake bug or a GitHub Actions image setup issue.

It's a bit sad to have to hardcode the value, and it means it might break again next time GitHub Actions update their macos-12 image, if they remove the 13.1 SDK. If anyone feels like digging into it further, feel free to. :)

For whatever reason CMake seems to infer "12.6" as SDK version, because
the GitHub Action macOS runner is based on macOS 12.6. But that number
doesn't match the SDK version, which should be 13.1 here.

This seems to be a long running issue with GitHub Actions' macOS runner:
actions/runner-images#2211

Though I can't tell if it's a CMake bug or a GitHub Actions image setup
issue.
@autious autious merged commit 73a9fed into WolfireGames:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants