dispose of producer in deinit #24
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash where if the ReactiveArray was initialized with a producer and the producer sends a value after the ReactiveArray has been dealloced, the app will crash on calling a method on unowned dealloced self in _signal.observe.
Easiest way to reproduce this bug is using a mirror:
There may be better ways to fix this than my solution, so feel free to implement your own.
I would have liked to use
.takeUntil(willDeallocSignal)
instead of the disposeBag, but I dont have awillDeallocSignal
for arbitrary swift classes (not NSObject)I could tackle this by disposing of the _signal.observe to prevent other possible problems of this kind, but I felt like my change fixes this particular problem as locally as possible.