Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Commit

Permalink
Fix analyzer warnings for frontend_server change (flutter#16470)
Browse files Browse the repository at this point in the history
- added temporary ignore for annotate_overrides analyzer warning,
  will remove the ignore in a follow-up PR after the SDK change
  https://dart-review.googlesource.com/c/sdk/+/134561 lands.
- run dartfmt
  • Loading branch information
Anna Gringauze authored Feb 6, 2020
1 parent ca40f11 commit c9e7713
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions flutter_frontend_server/lib/server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,13 @@ class _FlutterFrontendCompiler implements frontend.CompilerInterface {
expression, definitions, typeDefinitions, libraryUri, klass, isStatic);
}

// ignore: annotate_overrides
Future<Null> compileExpressionToJs(
String libraryUri,
int line,
int column,
Map<String,String> jsModules,
Map<String,String> jsFrameValues,
Map<String, String> jsModules,
Map<String, String> jsFrameValues,
String moduleName,
String expression) {
throw UnimplementedError('Compile expression to JS is not supported');
Expand Down Expand Up @@ -154,7 +155,8 @@ Future<int> starter(

compiler ??= _FlutterFrontendCompiler(output,
transformer: transformer,
unsafePackageSerialization: options['unsafe-package-serialization'] as bool);
unsafePackageSerialization:
options['unsafe-package-serialization'] as bool);

if (options.rest.isNotEmpty) {
return await compiler.compile(options.rest[0], options) ? 0 : 254;
Expand Down

0 comments on commit c9e7713

Please sign in to comment.