Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo and correct the directory path when auto downloading dataset #20

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

SamWang0807
Copy link
Contributor

@SamWang0807 SamWang0807 commented Jun 2, 2024

In dataset_preparation.py, the path that stores the downloaded dataset should be under "final_path", instead of "extract_to".
Also, import path of "custom_logger" function typo is fixed.

  • The code follows the Python style guide.
  • Code and files are well organized.
  • All tests pass.
  • New code is covered by tests.
  • We would be very happy if gitmoji😆 could be used to assist the commit message💬!

@henrytsui000
Copy link
Collaborator

Hi Sam,

Thank you for your contributions! I've reviewed the changes and they look good to me. All tests are passing, which is great. I'll proceed with merging this PR.

Thanks again for your attention to detail and your efforts!

Best regards,
Henry Tsui

@henrytsui000 henrytsui000 merged commit 24b85bd into WongKinYiu:main Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants