Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing touch command, Fix named Volume in compose file, Fix needless downloading of docker-compose #235

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

AIndoria
Copy link
Contributor

@AIndoria AIndoria commented Jul 12, 2023

Hello,

Currently, there are two minor issues with the deployments file:

  1. The touch command will fail as touch does not create directories. a mkdir beforehand is necessary. However, the docker-compose.yml file simply specifies the database as
volumes:
      - db_sqlite3:/app/db.sqlite3

which would not create the necessary dbfile in the current directory, but a named volume instead - which doesn't work for this instance as compose will just throw an error (unless a volume is specified separately on root of compose file). Thus I have changed this to ./db_sqlite3. Additionally, if creating a specific directory is desired, I can modify that as well.

  1. the check for if compose is installed only takes into account if it is installed as docker-compose. However, docker compose exists and used by many (myself included). This modification checks for both, and uses the appropriate installation method to do the up -d .

Might fix #146

@WongSaang
Copy link
Owner

Thank you for your great job

@WongSaang WongSaang merged commit c5ecba3 into WongSaang:main Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add database
2 participants