-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump ws from 7.4.6 to 7.5.10 #114
Conversation
Bumps [ws](https://github.com/websockets/ws) from 7.4.6 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.4.6...7.5.10) --- updated-dependencies: - dependency-name: ws dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Caution Review failedThe pull request is closed. WalkthroughThe change involves updating the version of the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
Client->>Server: Establish WebSocket connection
Server-->>Client: Connection established
Client->>Server: Send message
Server-->>Client: Acknowledge message
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
Files selected for processing (1)
- package.json (1 hunks)
Additional comments not posted (1)
package.json (1)
103-103
: LGTM! But verify compatibility.The
ws
package version is updated from7.4.6
to7.5.10
. Ensure that the new version is compatible with the existing codebase.The code changes are approved.
Run the following script to verify compatibility:
Verification successful
Compatibility Verified for
ws
Package UpdateThe update of the
ws
package to version7.5.10
appears to be compatible with the current usage in the codebase. TheWebSocket
is used in a straightforward manner, and no breaking changes are expected with the new version.
lib.commonjs/providers/ws.js
: ExportsWebSocket
.lib.esm/_admin/test-browser.js
: UsesWebSocket
for connection and error handling.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of the new `ws` package version. # Test: Check for any breaking changes or compatibility issues. npm ls wsLength of output: 82
Script:
#!/bin/bash # Search for any require or import statements for the `ws` package in the codebase. ast-grep --lang javascript --pattern 'require("ws")' ast-grep --lang javascript --pattern 'import $_ from "ws"'Length of output: 238
Script:
#!/bin/bash # Search for the usage of `ws_1` in `lib.commonjs/providers/ws.js`. rg 'ws_1' lib.commonjs/providers/ws.js -A 5 # Search for the usage of `WebSocket` in `lib.esm/_admin/test-browser.js`. rg 'WebSocket' lib.esm/_admin/test-browser.js -A 5Length of output: 818
Quality Gate passedIssues Measures |
Bumps ws from 7.4.6 to 7.5.10.
Release notes
Sourced from ws's releases.
... (truncated)
Commits
d962d70
[dist] 7.5.1022c2876
[security] Fix crash when the Upgrade header cannot be read (#2231)8a78f87
[dist] 7.5.90435e6e
[security] Fix same host check for ws+unix: redirects4271f07
[dist] 7.5.8dc1781b
[security] Drop sensitive headers when following insecure redirects2758ed3
[fix] Abort the handshake if the Upgrade header is invalida370613
[dist] 7.5.71f72e2e
[security] Drop sensitive headers when following redirects (#2013)8ecd890
[dist] 7.5.6Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit