Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Course Feedback] Create a Block Theme (Low-Code) - Module #5 Feedback Template #1277

Closed
wparasae opened this issue Jan 23, 2023 · 4 comments
Assignees

Comments

@wparasae
Copy link
Collaborator

wparasae commented Jan 23, 2023

Related to Course: Course: Create a Block Theme (Low-Code) - Course #1 #631

In an attempt to reduce clutter on the Training Team Github board and simplify everyone's lives, I'm creating this template to collect public feedback on the final module in the course, Develop Your First Low-Code Block Theme.

**Lessons **
Please review each lesson below in a comment on this Github issue

  1. Completing Your Custom Theme: Taking a Screenshot (Preview here)
  2. Completing Your Custom Theme: Adding Information in style.css (Preview here)
  3. Theme Enhancements - Offering Reusable Blocks, Unique Templates, Unique Patterns, Style Variations (Review here)
  4. You're Almost Finished! What's Next? (Review here)

Add a comment to this post. Some suggested questions:

  1. What was clear to you? What could use additional information?
  2. Is anything technically incorrect with this information? If so, what change should be made?
  3. Do you see any typos? What are they?

Please add comments for lessons in module #5 in this singular Github issue. Thank you!

@wparasae
Copy link
Collaborator Author

Review #1 (Thanks @westnz !) - Google Doc

@nomad-skateboarding-dev
Copy link

nomad-skateboarding-dev commented Jan 26, 2023

Impression overall for this module: the most fun and informative module I've taken on Learn! I feel like this whole course gave me more knowledge and confidence as a block theme developer than most of my previous studies outside of WordPress.org. 🙂👏

Completing your custom theme taking a screenshot

  1. The reminder to refresh to see changes is a key item. Well done.

Adding information in style.css

  1. This might be the most helpful page I've come across so far for my block theme development journey. 😀🙌
  2. Should the word "if" appear before "you" highlighted in this screenshot?Screenshot_20230125-194647.png

Theme enhancements
1.This was awesome. I really liked the reminder at the bottom on keeping it simple!

Final steps

  1. The second sentence of step 2 reads a little fuzzy to me? 🙂 For myself, 'Type the new name to the custom theme template name.' reads great! (It also makes the three steps seem that much shorter with less words. 😅)
    Screenshot_20230125-195945.png

In Course Menu
In the course menu on mobile view, section 5 of module 3 doesn't display fully. All the other sections display.

  1. Tested on Chrome and Firefox mobile browsers.
    Screenshot_20230125-233534.png

@wparasae
Copy link
Collaborator Author

I've made all recommended changes ^ above -- I'm not sure what's going on with the mobile menu yet, so I will look into this once the course is published and see if we can replicate that somewhere else on another course, or if it's just this one. Thank you for pointing that out!

@wparasae
Copy link
Collaborator Author

I double-checked with @jonathanbossenger over a technical question I had; he also reviewed the last module for accuracy, and I corrected a small misconception of my own. I think this is just about ready!

@wparasae wparasae moved this from 🔎 Review in Progress to 📜 Published or Closed in LearnWP Content - Development Feb 1, 2023
@kaitohm kaitohm closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📜 Published or Closed
Development

No branches or pull requests

3 participants