Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshops Archive #5

Closed
StevenDufresne opened this issue Aug 4, 2020 · 11 comments · Fixed by #107
Closed

Workshops Archive #5

StevenDufresne opened this issue Aug 4, 2020 · 11 comments · Fixed by #107
Labels
[Component] Learn Theme Website development issues related to the Learn theme. Priority - High High priority issue.

Comments

@StevenDufresne
Copy link
Contributor

StevenDufresne commented Aug 4, 2020

workshop-archive

Filter UI:
workshop-archive-filter

https://www.figma.com/file/UtmG8KQv3Csy8hNtuAWkwZ/Learn-WordPress?node-id=51%3A3565

Features

Milestone 1

  • Workshop list

Milestone 2

  • Search
  • Filters
  • Advanced Features
@StevenDufresne StevenDufresne changed the title Workshop Archive Workshops Archive Aug 4, 2020
@coreymckrill coreymckrill added the [Component] Learn Theme Website development issues related to the Learn theme. label Aug 6, 2020
@hlashbrooke hlashbrooke added the Priority - High High priority issue. label Aug 24, 2020
@StevenDufresne
Copy link
Contributor Author

@hlashbrooke Will the current /workshops be a subset of featured workshops (right now it just pulls everything...)?

If it is a subset of featured workshops, any preferred method for managing them? (Ie. Category, CPT, etc.)

Additionally, the home page links to "View All" in the "Recent" category, does that link go to the archive page depicted here or the landing page? If it doesn't go to the landing page, I don't see how users will ever be able to find their way to it. Maybe "View All" would make more sense as a "View more"?

@hlashbrooke
Copy link
Collaborator

/workshops should just pull all the workshops (as it does now) - there's no need for a "featured workshops" section I don't think.

Could you explain what you see as the difference between the workshop archive and the workshop landing page? The way I see it, there should only be one workshop archive/landing page with the filters.

@StevenDufresne
Copy link
Contributor Author

Yep, in the initial design, we have 2 different views of workshops.

Workshop Lander:
We implemented this already.

https://www.figma.com/file/UtmG8KQv3Csy8hNtuAWkwZ/Learn-WordPress?node-id=106%3A0

Workshop Archive:
Not implemented

https://www.figma.com/file/UtmG8KQv3Csy8hNtuAWkwZ/Learn-WordPress?node-id=51%3A3364

It isn't clear to me how they relate since the designs are different. Do we add the filtering above the large featured workshop we have currently? Or do we build out an archive page with filtering & search & paging.

@hlashbrooke
Copy link
Collaborator

The idea there is that the initial lander would be for when there's not much content on the site and the second mock-up for the archive with the filters is for when we have enough content for that, so it would replace the older one.

In terms of layout, the mockup with the filtering is where we want to be moving forward - the inital layout with the large featured image was just there since we have so few workshops to start.

@StevenDufresne
Copy link
Contributor Author

Thanks for clarifying.

@StevenDufresne
Copy link
Contributor Author

StevenDufresne commented Aug 28, 2020

What about something like this? The tags do a good job explaining the type, although they are a bit loud.

Disregard the inconsistencies with the titles and the missing tags on item 3 & 4.

@hlashbrooke
Copy link
Collaborator

I assume this comment was meant to be on #38 instead? I like the design! And I think it works well for the use case.

@StevenDufresne
Copy link
Contributor Author

I assume this comment was meant to be on #38 instead? I like the design! And I think it works well for the use case.

Meep! Meep! Definitely wrong ticket :) .

@coreymckrill
Copy link
Contributor

In the process of building the logic for the filters and the functions for outputting all the available options for each of the filter parameters, it occurred to me that having a column of checkboxes inside a togglable "drawer" won't scale very well when there are dozens of options for any particular parameter. The Language and Captions parameters especially will probably eventually have dozens available, but I could also see dozens of different topics and series as well.

With that in mind, in #107 I started going down the path of using Select2 SelectWoo dropdowns for each of the filter parameters instead of checkboxes. The advantage is that you can find the option you want by beginning to type in the dropdown field and choosing from the partial match results that it shows. Plus, the drawer will always be the same size regardless of how long the list gets for a particular parameter. Here's what it looks like right now:

new-filter-drawer

@StevenDufresne pointed out that having to click to open the drawer and then click again to open one of the dropdowns is not great UX, and it made me think that maybe we don't need the togglable drawer at all, we could just show the dropdowns in a bar at the top of the page.

I'd love to get some designer eyes and mind on this. @melchoyce ?

@melchoyce
Copy link

I figure'd we'd reuse the existing feature filter we have on themes so I didn't put any extra thought into it. Scalability is a good concern here. Would something like this work?

image

coreymckrill added a commit that referenced this issue Sep 11, 2020
Based on this conversation:
#5 (comment)

* Move the search box to it's own component template file and put it up
  by the page title, and remove the upper Submit a Workshop button
  (there's still one at the bottom).
* Move the filter controls to an always visible bar beneath the page
  title. Simplify the markup a bit.
@coreymckrill
Copy link
Contributor

@melchoyce I like this. We still need to have buttons for Apply Filters and Clear All, so in my latest commit I've put them in a fifth column:

filter-no-drawer

I'm not sure about listing the items beneath when they are selected. I was kind of thinking they would be single select instead of multiple. But if we do go multiple, what would be the behavior if you keep on adding more language selections? Would it bump all the content beneath it down?

coreymckrill added a commit that referenced this issue Sep 16, 2020
Adds a filter/search UI to the archive workshop view. Also makes updates to other parts of the project in order to facilitate filtering:

* Adds a way to get a locale name from its code
* Updates the Edit Workshop screen's metabox to use dropdowns to choose language and captions

Fixes #5 

Co-authored-by: Corey McKrill <916023+coreymckrill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme. Priority - High High priority issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants