Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Video player proportions for the "Contribute" page #1660

Open
foosantos opened this issue Jun 28, 2023 · 3 comments
Open

Bug report: Video player proportions for the "Contribute" page #1660

foosantos opened this issue Jun 28, 2023 · 3 comments
Assignees
Labels
Priority - Medium Medium priority issue. [Type] Bug Something isn't working on the Learn website. [Type] Good First Issue Good website development issue for new contributors.

Comments

@foosantos
Copy link
Member

Description

The player proportions for videos on steps 3 and 4 need to be corrected for the Contribute page. They are small and not aligned with step 5.

Markup 2023-06-27 at 16 54 51

Step-by-step reproduction instructions

  1. Go to the Contribute page.
  2. Scroll down to steps 3 and 4, and see the difference compared with step 5.

Expected behaviour

Show with the same dimensions (width and height) added to step 5.

Actual behaviour

It is too small, and even the player controls aren't showing as expected because of the width.

Screenshot 2023-06-27 at 21 22 13

Environment information

  • Browser(s) are you seeing the problem on: Chrome Version 114.0.5735.133 (Official Build) (arm64)
  • Device you are using and operating system: MacBook Pro (Apple M2 Pro) - macOS 13.4 (22F66)
@foosantos foosantos added [Type] Bug Something isn't working on the Learn website. Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Jun 28, 2023
@cynthianorman
Copy link
Contributor

Just a note on the difference between #5 and the other 2 iframes (#3 & #4). The video for #5 looks like it was embedded using a different method. See screenshot. https://snipboard.io/Zpwihc.jpg

@jonathanbossenger
Copy link
Collaborator

In reviewing this page during dev-squad triage, the third video is added to the page via a shortcode, whereas the first two are added as video blocks. So we should either download and add that third video, or use the shortcode method for the first two.

@jonathanbossenger jonathanbossenger added Priority - Medium Medium priority issue. Quick Fix and removed Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Sep 7, 2023
@kaitohm kaitohm added [Type] Good First Issue Good website development issue for new contributors. and removed Quick Fix labels Nov 27, 2023
@cynthianorman cynthianorman self-assigned this Jan 26, 2024
@cynthianorman
Copy link
Contributor

I can work on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - Medium Medium priority issue. [Type] Bug Something isn't working on the Learn website. [Type] Good First Issue Good website development issue for new contributors.
Projects
Status: To do
Development

No branches or pull requests

4 participants