-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workshop Post Type #3
Comments
Some more questions:
It kind of seems like these could all just be lumped into the normal block editor content field:
Perhaps new workshop posts just start with a default block pattern as a template that can then be modified? |
The videos definitely won't live on wporg infrastructure, so they'll be hosted by a video streaming service (wp.tv or YouTube). Perhaps the list of allowed platforms would only be limited by which ones Core supports for embedding, but that would be more of a policy question. As long as we're relying on Core embed support, we won't need any special plugins, and blocks should already exist for them. |
For the workshop landing page and archives, it looks like we need to be able to pull out the (first?) video from a particular workshop post in the case that it's featured, and also a still from the video for when it's displayed in a grid of workshops. So each post probably also needs:
|
Noting: When you get a chance, please turn on feature images for the CPT. |
I've done this. Nevermind. |
A manual solution could be to simply add a link to the content when loading the workshop, but a more elegant solution would be an additional
The way I see it, we could either have it (and the other data) as custom fields, or we could create post templates in gutenberg and then use those - that would eliminate the need for custom fields, but it would also provide the same structure for each workshop post, but still allowing for some flexibility if needed.
I would say the presenter should be a custom field, like it is for WordCamp sessions. That way we can add a comma-separated list of .org usernames and it would show however many we need on the frontend. If the presenter is the author then it would be tough to account for multiple presenters. |
On a fresh install running trunk (38c404c), I get a white screen when browsing to http://localhost:8888/wp-admin/post-new.php?post_type=wporg_workshop The browser did receive source; it's attached. add-workshop.html.txt Here is Chrome's Developer Tools Console as well. This is happening on the post editor screens for new and edits to exiting pages, posts, lesson-plans and workshop. Disabling the Jetpack plugin allows the post editor screens to load. |
The only thing left on this, as far as I can tell, is having a way to show the video from a workshop in other places besides the single workshop view. #73 is one idea to address this, which we may or may not implement. Either way, I'm going to close this in favor of that PR for now. |
https://www.figma.com/file/UtmG8KQv3Csy8hNtuAWkwZ/Learn-WordPress?node-id=15%3A1390
Features:
Excerpt from tardis regarding content:
We should probably write these as blocks within a post template?
Questions:
The text was updated successfully, but these errors were encountered: