Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Show video for featured workshop on lander instead of thumbnail #73

Closed
wants to merge 1 commit into from

Conversation

coreymckrill
Copy link
Contributor

@coreymckrill coreymckrill commented Aug 12, 2020

The mockup appears to call for the video of the featured workshop to be embeded at the top of the lander page, rather than a featured image.

https://www.figma.com/file/UtmG8KQv3Csy8hNtuAWkwZ/Learn-WordPress?node-id=106%3A0

Since the workshop post type doesn't have a meta field for the video URL, but instead just has a required video block, we can search for that block and render it individually on the lander page.

This would eliminate the need for the video URL meta field, as called for in #3

The mockup appears to call for the video of the featured workshop to be
embeded at the top of the lander page, rather than a featured image.

Since the workshop post type doesn't have a meta field for the video
URL, but instead just has a required video block, we can search for that
block and render it individually on the lander page.
@coreymckrill coreymckrill added the [Component] Learn Theme Website development issues related to the Learn theme. label Aug 12, 2020
@coreymckrill coreymckrill added this to the Soft Launch milestone Aug 12, 2020
@coreymckrill coreymckrill self-assigned this Aug 12, 2020
@StevenDufresne
Copy link
Contributor

Right, I wanted to cycle back here. Although the designs show a video, I find it weird because it appears to me like it needs to be watched within the context of the workshop to see the additional information (Outcomes & Comprehension).

If you start watching here and then click over, progress will be lost. With that in mind, I didn't see a use case where watching the video here made sense so used the feature image.

@coreymckrill
Copy link
Contributor Author

Good points. I do think having a giant featured image there is also a bit awkward. Thoughts @hlashbrooke @melchoyce?

@coreymckrill coreymckrill mentioned this pull request Aug 12, 2020
@dd32
Copy link
Member

dd32 commented Aug 12, 2020

Seems like as with #76 maybe the image should be a link, and/or have a fake play button that loads the workshop page?

@dd32
Copy link
Member

dd32 commented Aug 13, 2020

Seems like as with #76 maybe the image should be a link, and/or have a fake play button that loads the workshop page?

I ended up putting together an experiment of that, #89

@hlashbrooke
Copy link
Collaborator

Playing the video on the archive page isn't ideal - the solution of a play button overlay is good and I'd rather to go ahead with that than playing a video directly on the archive page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants