Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results: Differentiate between CPTs #38

Closed
hlashbrooke opened this issue Aug 10, 2020 · 5 comments
Closed

Search results: Differentiate between CPTs #38

hlashbrooke opened this issue Aug 10, 2020 · 5 comments
Labels
[Component] Learn Theme Website development issues related to the Learn theme. Priority - High High priority issue.

Comments

@hlashbrooke
Copy link
Collaborator

The search function searches the lesson plans and the workshops, but they are displayed in a single list with no visual distinction - example: https://learn.wordpress.org/?s=block

Could this be updated to show some sort of visual differentiator? Either a highlight of some kind or, better yet, display results in two columns/areas - one for each CPT.

@coreymckrill coreymckrill added the [Component] Learn Theme Website development issues related to the Learn theme. label Aug 10, 2020
@coreymckrill coreymckrill added this to the Next Iteration milestone Aug 10, 2020
@angelasjin
Copy link

I think the search function also searches beyond Learn WordPress. Is it supposed to do that? For example: https://learn.wordpress.org/?s=open+source

@CdrMarks
Copy link
Collaborator

CdrMarks commented Aug 11, 2020

@angelasjin I am seeing search results that include Lesson Plans which are part of this site. Are you seeing content in the search results not from this site?

@angelasjin
Copy link

On closer inspection, no. But that 2010 post from Jen really surprised me!

@hlashbrooke hlashbrooke added the Priority - High High priority issue. label Aug 24, 2020
@StevenDufresne
Copy link
Contributor

@hlashbrooke Do we have any examples within .org that we particularly like?

@hlashbrooke
Copy link
Collaborator Author

It would be great if the individual results could use the same design/layout as the plugin search results cards: https://wordpress.org/plugins/search/block/

In terms of differentiating between workshops and lesson plans, I don't know of any existing examples elsewhere on .org, but I was thinking the simplest solution could be a different background colour to highlight them. We could even use a green/blue like on the homepage CTAs, but much more faded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme. Priority - High High priority issue.
Projects
None yet
Development

No branches or pull requests

5 participants