-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the layout of items in search results. #109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenDufresne
changed the title
Try/search layout
Update the layout of items in search results.
Aug 31, 2020
Looks great to me! |
hlashbrooke
approved these changes
Aug 31, 2020
ryelle
reviewed
Aug 31, 2020
wp-content/themes/pub/wporg-learn-2020/css/settings/_colors.scss
Outdated
Show resolved
Hide resolved
...ent/themes/pub/wporg-learn-2020/template-parts/component-post-card-footer-wporg_workshop.php
Show resolved
Hide resolved
wp-content/themes/pub/wporg-learn-2020/template-parts/component-post-card.php
Outdated
Show resolved
Hide resolved
wp-content/themes/pub/wporg-learn-2020/template-parts/component-post-card.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Kelly Dwan <ryelle@users.noreply.github.com>
StevenDufresne
force-pushed
the
try/search-layout
branch
from
September 1, 2020 23:41
eaaccef
to
581b8c3
Compare
ryelle
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;)
@@ -3005,12 +3005,6 @@ body, #pagebody { | |||
font-weight: 400; | |||
} | |||
|
|||
.site-main .no-results { | |||
margin: 0 auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Mine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the search results to differentiate between post types.
Addresses: #38
Screenshots