Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - Embeds block not appearing correctly on the front end #2091

Closed
westnz opened this issue Dec 8, 2023 · 6 comments · Fixed by #2179
Closed

Feedback - Embeds block not appearing correctly on the front end #2091

westnz opened this issue Dec 8, 2023 · 6 comments · Fixed by #2179
Assignees
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Type] Bug Something isn't working on the Learn website. [Type] Good First Issue Good website development issue for new contributors.

Comments

@westnz
Copy link
Collaborator

westnz commented Dec 8, 2023

Type of feedback

//dev

Description

Videos are not displaying correctly on the front end when added via the Embeds block. The video is more narrow than the text.

Step-by-step reproduction instructions (optional)

Please list the steps needed to reproduce or verify the feedback. For example:

  1. Add a YouTube video to a Sensei lesson via the Embeds block.
  2. Preview on the front end.

Screenshots or screen recording (optional)

If possible, please upload a screenshot or screen recording illustrating the feedback.
image

Other information (optional)

Please see this thread for more details: https://a8c.slack.com/archives/C02P7FHLVR9/p1701978404354329

@westnz westnz added the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Dec 8, 2023
@github-actions github-actions bot added the [Type] Bug Something isn't working on the Learn website. label Dec 8, 2023
@jonathanbossenger
Copy link
Collaborator

It looks like the theme needs to have support for responsive embeds

@jonathanbossenger jonathanbossenger added [Component] Learn Theme Website development issues related to the Learn theme. and removed Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Dec 14, 2023
@jonathanbossenger jonathanbossenger self-assigned this Dec 14, 2023
@jonathanbossenger jonathanbossenger added the [Type] Good First Issue Good website development issue for new contributors. label Dec 14, 2023
@jonathanbossenger
Copy link
Collaborator

@westnz can I check, is the plan to start publishing Learning Pathway Lessons before the new site launch is completed?

The reason I ask is that if we only need this once the new site is launched, then the new theme will have support for responsive embeds by default, and this work will not be required.

@westnz
Copy link
Collaborator Author

westnz commented Dec 18, 2023

Good point! The aim is to publish the learning pathways end of July. I assume the new site will also be launched before that or coincide with the publishing of learning pathways.

@westnz
Copy link
Collaborator Author

westnz commented Jan 17, 2024

@jonathanbossenger, if we aim to publish some pathways before launch, would this bug not need to be fixed before the new site launch?

@jonathanbossenger
Copy link
Collaborator

@westnz yeah, that's a valid point. I am doing some other dev work with @bsanevans next week for student reporting, so I will look into that at the same time.

@jonathanbossenger
Copy link
Collaborator

@westnz I have created the PR to fix this, and it appears to work locally, but we'll just have to test it on Learn. I will get this merged and deployed alongside the student reporting fix sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Type] Bug Something isn't working on the Learn website. [Type] Good First Issue Good website development issue for new contributors.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants