Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to count unique learners #2161

Closed
wants to merge 5 commits into from

Conversation

kaitohm
Copy link
Contributor

@kaitohm kaitohm commented Jan 18, 2024

Adds the script provided by @m1r0 in #2111 to wporg-learn plugin

Adds the script provided by @m1r0 in #2111 to wporg-learn plugin
@kaitohm kaitohm marked this pull request as draft January 18, 2024 09:19
@kaitohm
Copy link
Contributor Author

kaitohm commented Jan 18, 2024

I'll come back to clean up those errors tomorrow.

@kaitohm
Copy link
Contributor Author

kaitohm commented Jan 19, 2024

I've given it my best shot, but I'm unsure how to fix the remaining three errors.
@jonathanbossenger Could you have a look at this for me, please? Thanks 🙇

@jonathanbossenger
Copy link
Collaborator

@bsanevans sure thing. Would you prefer to see the fixes and explanations during a call, or would you prefer me to push the fixes to this PR, with a summary of the changes and why the PHP static analysis tool requires them?

@jonathanbossenger jonathanbossenger added [Component] Sensei Website development issues related to the Sensei plugin installed on Learn. and removed [Component] Sensei Website development issues related to the Sensei plugin installed on Learn. labels Jan 19, 2024
@kaitohm
Copy link
Contributor Author

kaitohm commented Jan 23, 2024

Closing in favor of #2172 .

@kaitohm kaitohm closed this Jan 23, 2024
@kaitohm kaitohm deleted the 2111-count-unique-learners branch January 23, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants