Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excerpt to the post type and grab the latest workshop for now, instead of a featured one. #33

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

StevenDufresne
Copy link
Contributor

Description

This PR:

  • Turns on the excerpt field to be used in the featured workshop section of the workshop archive.
  • Grabs only one workshop to display
    • Categories were removed from workshops because they are currently creating issues with lesson-plan code.

@StevenDufresne
Copy link
Contributor Author

Related: #4

Copy link
Contributor

@coreymckrill coreymckrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of a known issue with excerpt generation and the core/group block (which is part of our block template for workshops), excerpts will not be automatically generated, so we'll have to add a manual one for each workshop that might get "featured". I'll open a separate issue here to keep tabs on the upstream issue.

@coreymckrill coreymckrill merged commit 2ca3841 into trunk Aug 10, 2020
@coreymckrill coreymckrill deleted the update/feature-workshop-excerpt branch October 8, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants