Explicitly recommend v0.4.1+ of the DealerDirect Composer plugin #1077
Conversation
|
PHPCSStandards/composer-installer#33 is fixed, closed and solved. I've released version v0.4.1 of the plugin, which should make this PR obsolete? |
GaryJones
dismissed
their stale review
Redundant, now that 0.4.1 of the DealerDirect plugin has solved the immediate issue.
Version 0.4.0 of the DealerDirect Composer plugin registers each standard individually as if they were root-directory standards, not a collection of standards which exposes a bug in PHPCS 3.x. Refs: * squizlabs/PHP_CodeSniffer/pull/1581 * PHPCSStandards/composer-installer/issues/33
jrfnl
changed the title
|
@GaryJones @frenck I've updated the PR to explicitly recommend version 0.4.1+ |
jrfnl
force-pushed
the
feature/recommend-dealerdirect-v0.3
branch
from
c71684e to
4f41c4b
Compare
|
@GaryJones @JDGrimes Does this change warrant an entry in the Changelog PR #1058 ? Or is it enough that Composer users will see this when they run Composer ? |
| @@ -65,7 +65,7 @@ For the convenience of using `phpcs` as a global command, you may want to add th | |||
| When installing the WordPress Coding Standards as a dependency in a larger project, the above mentioned step 3 will not be executed automatically. | |||
|
|
|||
| There are two actively maintained Composer plugins which can handle the registration of standards with PHP_CodeSniffer for you: | |||
| * [composer-phpcodesniffer-standards-plugin](https://github.com/higidi/composer-phpcodesniffer-standards-plugin) | |||
| * [composer-phpcodesniffer-standards-plugin](https://github.com/higidi/composer-phpcodesniffer-standards-plugin):"^0.4.1" | |||
There was a problem hiding this comment.
@jrfnl You've added the version restriction in the documentation (README.md) to the wrong plugin.
There was a problem hiding this comment.
@frenck Oh darn it! Thanks for catching that. Will fix this straight away.
There was a problem hiding this comment.
See #1078 - I would merge it straight away, but for the fact that at least one person other than the pullee has to approve it 😬
|
@jrfnl I'm indifferent to whether or not we note this in the changelog. |
|
No need to mention it in our change log. Someone can dig into the DealerDirect plugin issues if they want to know the reason we happen to recommend a particular version in the Readme. |
Version 0.4.0 of the DealerDirect Composer plugin registers each standard individually as if they were root-directory standards, not a collection of standards, which exposes a bug in PHPCS 3.x.
Refs:
installed_pathssquizlabs/PHP_CodeSniffer#1581