Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in test file #1123

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Sep 7, 2017

Wasn't impeding the unit tests or anything, but was causing issues when I was running some tests to detect fixer conflicts.

Fixing the syntax error will allow for adding an additional test to the travis run to automatically check for fixer conflicts based on the existing unit tests at some point in the future.

For this additional travis test to be added, upstream PR squizlabs/PHP_CodeSniffer#1645 will need to be merged first.

Wasn't impeding the unit tests or anything, but was causing issues when I was running some tests to detect fixer conflicts.

Fixing the syntax error will allow for adding an additional test to the travis run to automatically check for fixer conflicts based on the existing unit tests at some point in the future.
@jrfnl jrfnl added this to the 0.14.0 milestone Sep 7, 2017
@westonruter westonruter merged commit 4c40769 into develop Sep 8, 2017
@westonruter westonruter deleted the feature/fix-syntax-error-in-test-file branch September 8, 2017 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants