Add a couple of extra sniffs to Extra
#1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of sniffs which were previously in VIP are also useful for `Extra`. The messages in these sniffs have - where appropriate - been downgraded to warnings. This commit adds these sniffs to the `Extra` ruleset. Note: There are three more candidates for this: * `DB.DirectDatabaseQuery` * `DB.SlowDBQuery` * `Security.ValidatedSanitizedInput` I've not included the first two (yet) as those may need some more discussion first. The third one is not included as it throws a lot of noise messages and has quite some open issues surrounding it, which should be addressed first IMO.
|
It's funny, as when I was reviewing the renaming PR, I started to ask the question as to whether that meant that Extra would benefit now some of them are less VIP-specific, but I checked the code again and saw that they didn't. |
GaryJones
approved these changes
Dec 14, 2017
|
@GaryJones grin Some things are better pulled step-by-step, also to avoid conflicts. I prepared these PRs all in one go and am pulling them one after another. One more after this one. |
JDGrimes
approved these changes
Dec 15, 2017
JDGrimes
deleted the
feature/1157-add-some-previous-VIP-rules-to-extra
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of sniffs which were previously in VIP are also useful for
Extra. The messages in these sniffs have - where appropriate - been downgraded to warnings.This commit adds these sniffs to the
Extraruleset.Note: There are three more candidates for this:
DB.DirectDatabaseQueryDB.SlowDBQuerySecurity.ValidatedSanitizedInputI've not included the first two (yet) as those may need some more discussion first.
The third one is not included as it throws a lot of noise messages and has quite some open issues surrounding it, which should be addressed first IMO.