Fix typos #2472
Merged
Fix typos #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Aug 7, 2024
| public function is_targetted_token( $stackPtr ) { | ||
| public function is_targeted_token( $stackPtr ) { |
There was a problem hiding this comment.
There is a public method name change here.
There was a problem hiding this comment.
From a quick search on the GH there are some external standards which seem to be using this abstract class, so changing this public method would be a major BC break IIRC.
There was a problem hiding this comment.
Okay, reverting ...
dingo-d
requested changes
Aug 7, 2024
| public function is_targetted_token( $stackPtr ) { | ||
| public function is_targeted_token( $stackPtr ) { |
There was a problem hiding this comment.
From a quick search on the GH there are some external standards which seem to be using this abstract class, so changing this public method would be a major BC break IIRC.
dingo-d
approved these changes
Aug 7, 2024
jrfnl
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found few misspellings.
Remaining ones: "post_statusses" and cachable
https://github.com/crate-ci/typos