Skip to content

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Sep 30, 2025

Follow up for #76.
Closes #67.

Addresses feedback from @justlevine:

I'm sorry to be pedantic, but as #76 (comment) the REST API uses check_{_}permissions() plural, even though the registry arg is permission_callback. It's also more grammatically accurate when paired with the verb check.

@gziolo gziolo self-assigned this Sep 30, 2025
@gziolo gziolo added the [Type] Bug Something isn't working label Sep 30, 2025
Copy link

github-actions bot commented Sep 30, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: Ref34t <mokhaled@git.wordpress.org>
Co-authored-by: johnbillion <johnbillion@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.69%. Comparing base (8e0b08a) to head (99824fa).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk      #94   +/-   ##
=========================================
  Coverage     85.69%   85.69%           
  Complexity      103      103           
=========================================
  Files            16       16           
  Lines           776      776           
  Branches         86       86           
=========================================
  Hits            665      665           
  Misses          111      111           
Flag Coverage Δ
javascript 92.66% <ø> (ø)
unit 82.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@gziolo gziolo merged commit 80f47ee into trunk Oct 1, 2025
36 of 37 checks passed
@gziolo gziolo deleted the update/rename-check-permissions branch October 1, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename usage of has_permission() to account for a WP_Error
2 participants