This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Implement different hydration techniques #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think we should include media-query-based hydration? Astro does, but you have to specify If the component is already hidden and shown by a media query in your CSS, then it can be easier to just use client:visible and not pass that same media query into the directive. In this case, if we don't include the option and just rely in CSS and its visible property, we would be skipping some use cases. |
cbravobernal
changed the title
michalczaplinski
approved these changes
May 13, 2022
|
Just a small note here if/when we propose this in Gutenberg: the intersection observer should also have a fallback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
I added an initial approach to the different hydration techniques as Astro (copy-pasted from the issue and Astro's codebase, mainly).
Should be the technique a prop in block.json rather than an attribute? (I guess choosing the hydration technique on the editor is an overkill)
Should we allow the Block developer to choose the hydration technique or is it a complex concept for most developers? (I still have to check some docs about IntersectionObserver and RequestIdleCallback)