Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Remove the router and leave only the Island hydration #216

Merged
merged 7 commits into from
Apr 18, 2023

Conversation

DAreRodz
Copy link
Collaborator

This is a simple PR that removes anything related to the router and client-side navigation, as they don't need to be included in Gutenberg at the moment.

  • Removed all code in router.js except the one for island hydration
  • Refactored e2e tests to use data-wp-island instead of the CSN meta tag
  • Removed e2e tests for full hydration and client-side navigation
  • Removed data-wp-link directive
  • Renamed router.js to hydration.js

Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM David! Feel free to merge.

src/runtime/hydration.js Outdated Show resolved Hide resolved
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
@DAreRodz DAreRodz merged commit 6d298c1 into refactoring-for-gutenberg Apr 18, 2023
@DAreRodz DAreRodz deleted the island-hydration-only branch April 18, 2023 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants