Add TT1 blocks #21
Add TT1 blocks #21
Conversation
| @@ -0,0 +1,11 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I think this file can go
There was a problem hiding this comment.
we can do it on a follow up where we also update the min required version of WordPress for the theme
| add_action( 'enqueue_block_editor_assets', 'tt1_blocks_block_editor_script' ); | ||
|
|
||
| // Block Styles. | ||
| require get_template_directory() . '/inc/block-styles.php'; |
There was a problem hiding this comment.
I think everything in this file except the style shared/blocks stylesheets and the block styles stuff can go, don't you think @carolinan ?
We can also discuss if those stylesheets can be consolidated into one if they end up being necessary at all
There was a problem hiding this comment.
I agree, and I think with more testing, many if not all the block styles should be removed too.
|
I think let's merge this one and continue working on separate PRs so the diffs are more meaningful to review, I think this still has a lot of work and there's a lot we can remove. |
|
I don't think this theme should be part of the repo. It's quite dated/uses a lot of CSS, functions, and isn't a great example of what a top-notch block theme is (today). There has been a lot of developments around theming since this was originally released. |
|
It wont be dated once we are ready to release the update. 🙂 |
|
To extend on my comment, yes it is dated right now, I am suggesting breaking backwards compatibility and updating the minimum required version to 6.2 and modernizing it. |
|
The reason why I think it's a good idea to include it in this repo is because TT1 blocks is already a community theme. It's already released under the WP username, and it's not being maintained. This way at the very least we ensure that the code is updated should people want to reference it at any point. |
|
I think we should remove the functions.php and all the CSS files. |
+1, we should lower the burden of maintenance as much as we can |
|
I opened issues for the removal of the code and other updates, if someone can ✅ this one, we can get the theme in the repo and start working on it? |
|
Thank you @carolinan let's make this one pretty |
This PR adds TT1 blocks to this repo. We should continue the work started in WordPress/theme-experiments#307 on this repo now and anything else that needs updating since the last time this theme had any work done.
/cc @carolinan
Closes #17