Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement suggestion: Font families panels #227

Closed
beafialho opened this issue Feb 16, 2023 · 6 comments
Closed

Improvement suggestion: Font families panels #227

beafialho opened this issue Feb 16, 2023 · 6 comments
Assignees

Comments

@beafialho
Copy link

beafialho commented Feb 16, 2023

Each font panel is so large it fills the entire screen, this makes it difficult to browse and edit the fonts:

Captura de ecrã 2023-02-16, às 11 43 06

I feel it would be an improvement is to:

  • Either have the fonts dropdowns collapsed by default
  • Or, even better, have a sidebar showing all the fonts uploaded to the theme, like this:

Captura de ecrã 2023-02-16, às 12 09 10

That way, it would be easier to browse and edit all the font families.

cc: @iamarinoh @iamtakashi

@matiasbenedetto
Copy link
Contributor

Hi @beafialho 👋
I have a few questions about the mockup:

  • Is the sidebar an outline of all the font families available, right?
  • What's the expected functionality from the three dots that appear at the right of the names?
  • For reading order clarity, what do you think about moving the sidebar to the right side? My rationale here is: as it appears to be an outline of the font families available, and those changes are done in the main part, it seems like the outline is a result of the content of the main view and it feels more natural to put it after the main area.
  • Not a question but a proposal: I think we could add a little bit more info about the fonts used, like the quantity of variants included and the total weight of the font assets.

@matiasbenedetto
Copy link
Contributor

matiasbenedetto commented Feb 17, 2023

Apart from that, I think we could split this issue into 2 items because the first one is very quick to implement.

@beafialho
Copy link
Author

Hi @matiasbenedetto!

Is the sidebar an outline of all the font families available, right?

That's right, like a summary with all the fonts on your theme.

What's the expected functionality from the three dots that appear at the right of the names?

I could see an "Edit" and "Remove" there. Maybe it could be divided with labels by "Local" and "Google" too for more clarity?

For reading order clarity, what do you think about moving the sidebar to the right side? My rationale here is: as it appears to be an outline of the font families available, and those changes are done in the main part, it seems like the outline is a result of the content of the main view and it feels more natural to put it after the main area.

Good point, I think that can work too 👍🏼

I think we could add a little bit more info about the fonts used, like the quantity of variants included and the total weight of the font assets.

Totally, where do you see that info showing?

@henriqueiamarino
Copy link

Maybe we could drink from the fountain of one of our greatest resources, Google Fonts.
This is how they deal with previews and styles, also offering different views such as Card and List.

Screenshot 2023-02-17 at 11 27 28

@beafialho
Copy link
Author

@henriqueiamarino it's a good reference! I have a preference for list as default, but having those two options sounds cool.

@matiasbenedetto
Copy link
Contributor

I'm closing this as completed in #260
Feel free to re-open if #260 only covers some of the expectations for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants