Cleanup Manage Theme Fonts UI #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for addressing this @jffng! One other thing I noticed recently that would be an improvement is to have the fonts dropdowns collapsed by default, each font panel is so large it fills the entire screen. That way, it would be easier to browse all the font families. A smaller default font size for the font's demo text could help with this too. |
matiasbenedetto
approved these changes
Feb 16, 2023
|
@beafialho nice suggestions and thanks for opening up #227, we can address further improvements in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a few changes recommended by @beafialho:
I wonder if we should refactor more of the app to react before doing this.