Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Add Google Fonts section from vanilla JS to React app #194

Merged
merged 9 commits into from
Feb 2, 2023

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Jan 27, 2023

This PR refactors the "Add Google Fonts" section of the plugin. It moves the implementation from Vanilla JS to React.
This enables further improvements to the app with less effort and more code reusability.

@matiasbenedetto matiasbenedetto marked this pull request as draft January 27, 2023 07:10
@matiasbenedetto matiasbenedetto marked this pull request as ready for review February 1, 2023 04:43
@matiasbenedetto matiasbenedetto requested a review from a team February 1, 2023 05:03
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring work!

When I build this, I'm seeing a webpack warning about the size of the output index.js file:

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  index.js (868 KiB)

Should we split this up into multiple JS files now, or maybe we could do it in a separate PR?

@matiasbenedetto
Copy link
Contributor Author

matiasbenedetto commented Feb 2, 2023

Thanks for catching that @mikachan !
I think we can try to implement the code splitting as a part of another PR because it's not related to this refactor or this set of changes.

@matiasbenedetto matiasbenedetto added the enhancement New feature or request label Feb 2, 2023
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can try to implement the code splitting as a part of another PR because it's not related to this refactor or this set of changes.

Sounds good to me! I think this is good to merge in then 🚢

@matiasbenedetto
Copy link
Contributor Author

I created an issue as a follow up of the bundle size: #205

@mikachan mikachan deleted the refactor/google-fonts-to-react-app branch February 2, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants