-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Add Google Fonts section from vanilla JS to React app #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactoring work!
When I build this, I'm seeing a webpack warning about the size of the output index.js file:
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
index.js (868 KiB)
Should we split this up into multiple JS files now, or maybe we could do it in a separate PR?
Thanks for catching that @mikachan ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can try to implement the code splitting as a part of another PR because it's not related to this refactor or this set of changes.
Sounds good to me! I think this is good to merge in then 🚢
I created an issue as a follow up of the bundle size: #205 |
This PR refactors the "Add Google Fonts" section of the plugin. It moves the implementation from Vanilla JS to React.
This enables further improvements to the app with less effort and more code reusability.