Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloned themes: Add original theme name to readme.txt and style.css #232

Merged
merged 4 commits into from
Feb 21, 2023

Conversation

mikachan
Copy link
Member

@mikachan mikachan commented Feb 17, 2023

Resolves #223.

This adds the original theme name to the output readme.txt of a cloned theme.

It uses the following text: "[New Theme] is based on [Original Theme] ([Original Theme URL), (C) [Original Theme Author], [Original Theme License]([Original Theme License URL)"

readme.txt:
image

@carolinan
Copy link

carolinan commented Feb 17, 2023

To be picky :) , it needs to also include copyright and licence information.

@mikachan
Copy link
Member Author

That makes sense! Hmm, maybe the 'original theme' information should also sit under the Copyright section of the readme.txt file, rather than in the description. Something like:

== Copyright ==

[New Theme] WordPress Theme, (C) 2023
[New Theme] is distributed under the terms of the GNU GPL.

[New Theme] is based on [Original Theme], (C) 2022
[Original Theme] is distributed under the terms of the GNU GPL.

This program is free software: you can redistribute it and/or modify...

Copy link
Contributor

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as advertised.
LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How about leaving the name of the cloned original theme somewhere?
3 participants