Fix: composer scripts doesn't work on Windows #233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I added the --no-verify option on commit to prevent the large number of diffs created by lint-staged.
This PR fixes the composer's lint/format command to work on Windows.
As seen in the issue in the npm repository, npm scripts starting with
./
do not work on Windows. Therefore, I usedcomposer run-script
instead, as is done in the Gutenberg repository.In addition,
.phpcs.xml.dist
was renamed tophpcs.xml.dist
because the ruleset file name specified by the composer script does not exist.Confirm that the following commands work:
Should show errors.
Error should appear and the code should be formatted. To restore the automatically changed format, run
git checkout .
.