-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local fonts section implementation in React #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are mostly UI related but it's mostly working as expected, thanks!
Change the styles of this section to make it look as the rest of the font section as implemented in #260
So on PR 260 I see this is what adding a Google Font looks like:
On this PR, the local fonts page looks like this:
Should we aim to bring these closer together in this PR? For example, the padding and the layout are different. I think the initial state looks a bit "broken" until you load a font because there is no indication that the right column is reserved for the font preview:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements, thanks! I think it's in a spot we can merge and iterate. Pre-approving with a couple notes:
- Let's try and bring the Google Fonts and Local Fonts layout closer together in a follow up.
- I noticed a security warning when I ran
npm install
. So maybe runningnpm audit
and fixing the package vulnerabilities would be of good conscience.
What?
In this PR:
wght
variable axis.Why?
To allow us to implement the user ability to add more configuration options.
How to test:
For classic fonts:
For variable fonts:
wght
variable axis).