Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels around Google font family checkbox controls #297

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Add labels around Google font family checkbox controls #297

merged 2 commits into from
Apr 4, 2023

Conversation

mikachan
Copy link
Member

@mikachan mikachan commented Apr 1, 2023

This adds labels around the text related to the Google font checkboxes when adding Google fonts to a theme. This makes the options slightly easier to select, as you can now click any text in the corresponding table row to select a font family or variant.

Video

Screen.Recording.2023-04-01.at.21.45.38.mov

@mikachan mikachan added the enhancement New feature or request label Apr 1, 2023
@mikachan mikachan self-assigned this Apr 1, 2023
jffng
jffng reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as advertised! Code looks good, I just wonder about one thing UX wise — does it make sense that when you click on the row headers ("Weight", "Style", "Preview") it selects all the variants?

@mikachan
Copy link
Member Author

mikachan commented Apr 4, 2023

does it make sense that when you click on the row headers ("Weight", "Style", "Preview") it selects all the variants?

I also wasn't too sure about this, but I went with it because these labels are next to the 'select all' checkbox, so they're essentially the labels for it. I don't feel too strongly about it though. They may easily be clicked by accident too.

jffng
jffng approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's go with it then!

@mikachan mikachan merged commit 0374c69 into trunk Apr 4, 2023
@mikachan mikachan deleted the add/font-family-labels branch April 4, 2023 15:15
mikachan added a commit that referenced this pull request Apr 5, 2023
@mikachan
Squashed merge commit with trunk
a4397de 
commit 0374c69
Merge: 83de623 072da09
Author: Sarah Norris <sarah@sekai.co.uk>
Date:   Tue Apr 4 16:15:50 2023 +0100

    Merge pull request #297 from WordPress/add/font-family-labels

    Add labels around Google font family checkbox controls

commit 83de623
Merge: 58491a7 b814f29
Author: Sarah Norris <sarah@sekai.co.uk>
Date:   Tue Apr 4 16:13:48 2023 +0100

    Merge pull request #296 from WordPress/try/add-current-wp-version

    Add current WordPress version to style.css and readme.txt

commit 58491a7
Author: github-actions <github-actions@github.com>
Date:   Mon Apr 3 20:54:08 2023 +0000

    Version bump & changelog update

commit 3a58a30
Merge: bb36a3a fd779d3
Author: Jeff Ong <jonger4@gmail.com>
Date:   Mon Apr 3 11:27:38 2023 -0400

    Merge pull request #292 from WordPress/try/site-editor-overwrite

    Add Export (Clone) to site editor

commit fd779d3
Author: Jeff Ong <jonger4@gmail.com>
Date:   Mon Apr 3 11:26:11 2023 -0400

    Carry forward previous theme tags.

commit 072da09
Author: Sarah Norris <sarah@sekai.co.uk>
Date:   Sat Apr 1 21:39:54 2023 +0100

    Add checkbox labels to font family table header

commit 54318c6
Author: Sarah Norris <sarah@sekai.co.uk>
Date:   Sat Apr 1 21:39:22 2023 +0100

    Add checkbox labels to font family variants

commit b814f29
Author: Sarah Norris <sarah@sekai.co.uk>
Date:   Sat Apr 1 20:54:04 2023 +0100

    Add current WP version to readme.txt

commit f4070b2
Author: Sarah Norris <sarah@sekai.co.uk>
Date:   Sat Apr 1 20:53:50 2023 +0100

    Add current WP version to style.css

commit bb36a3a
Merge: b5a0a0a 8c4098a
Author: Matias Benedetto <matias.benedetto@gmail.com>
Date:   Fri Mar 31 17:35:57 2023 -0300

    Merge pull request #293 from WordPress/update/google-fonts-json-_4537839996

    Update Google Fonts JSON data from API

commit cd5f862
Author: Matias Benedetto <matias.benedetto@gmail.com>
Date:   Fri Mar 31 17:22:36 2023 -0300

    setting the filename of the exported zip file

commit b5a0a0a
Merge: e3f9193 260d115
Author: Matias Benedetto <matias.benedetto@gmail.com>
Date:   Fri Mar 31 13:05:52 2023 -0300

    Merge pull request #291 from WordPress/fix/280

    Fixing image downloading not working in some cases

commit 1b19d29
Author: Jeff Ong <jonger4@gmail.com>
Date:   Thu Mar 30 12:24:35 2023 -0400

    Make linter happy.

commit b86a1f1
Author: Jeff Ong <jonger4@gmail.com>
Date:   Thu Mar 30 12:23:42 2023 -0400

    Rename file.

commit 6efb440
Author: Jeff Ong <jonger4@gmail.com>
Date:   Wed Mar 29 17:27:42 2023 -0400

    Add validation to form button, improve spacing.

commit b5c6a17
Author: Jeff Ong <jonger4@gmail.com>
Date:   Wed Mar 29 17:11:01 2023 -0400

    Async/await, update icon, button.

commit 8bc38ef
Author: Jeff Ong <jonger4@gmail.com>
Date:   Wed Mar 29 16:40:00 2023 -0400

    Use tt3 as placeholder

    Co-authored-by: Ben Dwyer <ben@scruffian.com>

commit 16f3c5c
Author: Matias Benedetto <matias.benedetto@gmail.com>
Date:   Wed Mar 29 15:50:17 2023 -0300

    Implementing WordPress apiFetch replacing the browser's fetch function

commit 4870efb
Author: Jeff Ong <jonger4@gmail.com>
Date:   Mon Mar 27 17:47:44 2023 -0400

    Lint php.

commit ebdf773
Author: Jeff Ong <jonger4@gmail.com>
Date:   Mon Mar 27 17:47:22 2023 -0400

    Site editor rest API export.

commit a7b2de4
Author: Jeff Ong <jonger4@gmail.com>
Date:   Mon Mar 27 13:49:35 2023 -0400

    Add panel to sidebar in site editor.

commit 8c4098a
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Tue Mar 28 00:15:24 2023 +0000

    Updating file

commit 260d115
Author: Matias Benedetto <matias.benedetto@gmail.com>
Date:   Mon Mar 27 15:48:44 2023 -0300

    fixing image downloading not working in some cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jffng jffng jffng approved these changes

Assignees

@mikachan mikachan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikachan @jffng