-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix theme slug and textdomain for cloned, child and sibling themes. #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
changed the title
Fix/child themes slugs
Fix theme slug and textdomain for cloned, child and sibling themes.
Apr 4, 2023
If you want to test this fix you can uninstall your current version of the plugin and install this .zip that contains the changes done in this branch: create-block-theme.zip |
✅ Tested successfully
|
mikachan
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well for me!
Tested:
- Clone
- Child
- Sibling
The textdomain and slug are correct in all options ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR should fix set correctly the theme
slug
,textdomain, and 'template
for cloned, child, and sibling themes.Why?
Currently, that's not working OK because in some cases the
textdomain
,slug
andtemplate
remain unchanged when you create a clone, child or sibling theme using the plugin.How to test
Create a theme using clone, child, and sibling options.
Test that the theme
slug
,textdomain
andtemplate
for the created theme are updated on every file of the theme (style.css, templates, template parts, and patterns).Check that all other options still work as expected.
Fixes: #275
Fixes: https://wordpress.org/support/topic/creating-child-theme-forgets-to-replace-parent-theme-references-in-templates/