Fixing error checking #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Here's what I did to test:
- Added image to header
- Used the "Overwrite" option
- Verified that the image was written and appeared as expected
Approving since it fixes that issue. Though the original wp forum report suggested that it wasn't working on "Clone" — I tried on Clone and that options seems to work correctly (writes the asset) with and without this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function
add_media_to_local,we checked for an error to try to write the asset when we should check the opposite.The problem was introduced in this recent PR: #305
Fixes #309