Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tag duplication in exported theme #318

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix tag duplication in exported theme #318

merged 1 commit into from
Apr 13, 2023

Conversation

madhusudhand
Copy link
Member

@madhusudhand madhusudhand commented Apr 13, 2023 •
edited
Loading

This removes the duplication of tags including custom-tags in the exported theme.
And ads extra space between header and css contents

Before:

image

After:

image

Fixes: #317

@madhusudhand madhusudhand added the bug Something isn't working label Apr 13, 2023
@madhusudhand madhusudhand requested review from jffng and a team and removed request for jffng April 13, 2023 10:29
matiasbenedetto
matiasbenedetto approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as advertised.
LGTM 🚀

@madhusudhand madhusudhand merged commit a402b6f into trunk Apr 13, 2023
@madhusudhand madhusudhand deleted the fix/theme-dup-tags branch April 13, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasbenedetto matiasbenedetto matiasbenedetto approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clone option creates duplicate tags in style.css
2 participants
@madhusudhand @matiasbenedetto