Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent additional white space in font credits in readme.txt #373

Merged
merged 1 commit into from
May 16, 2023

Conversation

mikachan
Copy link
Member

When the font credits are added to the readme.txt file, they add an unnecessary line break above the font license info. This PR should fix this so that a new line break is only added when the readme.txt does not already have a line break at the end of the file. This line break above the font credits block should also be removed from the readme.txt when a font family is removed from the theme.

Testing instructions:

  1. Go to the Manage Theme Fonts page
  2. Add a new font
  3. Check that the font license info has been added to the theme readme.txt and that there is a line break between the previous end of the readme contents and the new font credits
  4. Go back to the Manage Themes Fonts page
  5. Remove a font family
  6. Check that the font license info has been removed from the readme.txt and there are no unnecessary line breaks left behind

Closes #361.

@mikachan mikachan self-assigned this May 16, 2023
Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised; LGTM.

@mikachan mikachan merged commit 118f015 into trunk May 16, 2023
@mikachan mikachan deleted the fix/font-license-readme-spaces branch May 16, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font removal: additional spaces are left in readme.txt from font license
2 participants