Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required node version and update dependencies #376

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

mikachan
Copy link
Member

This PR updates the required node version from 16.9.1 to 18, as I was seeing this error when trying to update dependencies:

image

It also updates all node dependencies.

Testing instructions

  1. Run rm -rf node_modules to delete your current node_modules
  2. If you use NVM, run nvm use to switch to node v18
  3. Run npm ci to install the updated modules from the package-lock file in this PR
  4. Try running npm start and npm run build - these commands should both run successfully

Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well for me, I did have to run npm i before npm ci though.

@mikachan mikachan merged commit 6fb06e6 into trunk May 23, 2023
@mikachan mikachan deleted the update-deps branch May 23, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants