Fix double replacement in replace_namespace #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was finally able to reproduce this! Thank you for your persistence in debuggin it @jffng and once I saw the fix I understood what I was missing in my steps to reproduce. This fixes the issue for me. |
pbking
approved these changes
Jun 5, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387. This PR alters the
replace_namespacefunction to use placeholders before performing the actual string replacement.When performing multiple replacements in the same string, some of the replacements can result in a string that matches an earlier search pattern. I think this is what's happening in #387.
To test
Follow the instructions in 387 on trunk and this PR, verify you don't get duplicated aspects of the old theme slug in the new theme slug.