Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modal width to 65vw #638

Merged
merged 5 commits into from
May 30, 2024
Merged

Update modal width to 65vw #638

merged 5 commits into from
May 30, 2024

Conversation

madhusudhand
Copy link
Member

This change brings the following UI changes.

  • Update the modal width of metadata editor and theme.json viewer to 65vw (similar to font library in core)
  • Makes the modal footer absolutely position in the bottom
image

In addition to these UI changes, it also introduces a style-sheet for adding class definitions.

@madhusudhand madhusudhand requested review from pbking, t-hamano and vcanales and removed request for pbking and t-hamano May 15, 2024 09:33
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Modal component can now define its width via the size prop. What do you think about using this prop instead of defining width in CSS? However, when using this props, the modal's height will not be full.

<Modal
	size="large"
>
</Modal>

image

admin/class-create-theme.php Outdated Show resolved Hide resolved
src/plugin-styles.scss Outdated Show resolved Hide resolved
@pbking
Copy link
Contributor

pbking commented May 22, 2024

What if additionally we shifted the 'screenshot' and 'subfolder' (two items that are pretty narrow) to a second, smaller column on the right?

image

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

admin/class-create-theme.php Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
@t-hamano t-hamano mentioned this pull request May 22, 2024
@t-hamano
Copy link
Contributor

What if additionally we shifted the 'screenshot' and 'subfolder' (two items that are pretty narrow) to a second, smaller column on the right?

I think this is an interesting idea and may be considered in another PR.

Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged /trunk and fixed a conflict and I think this is ready to come in too. It looks nice; thank you for doing this. :)

@matiasbenedetto
Copy link
Contributor

I fixed the conflicts to merge this and include it in the next release.

@matiasbenedetto matiasbenedetto merged commit 2c63cdc into trunk May 30, 2024
2 checks passed
@matiasbenedetto matiasbenedetto deleted the update-modal-ui branch May 30, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants