Add the block.json schema to each block.json file #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added schea defintion to each file, this allows validation and auto complete in supported browers. "$schema": "https://json.schemastore.org/block.json" Required fixing the textDomain => textdomain Highlighted an issue with `source: children` not documented.
In the attributes, The source of `children` is no longer supported and should be changed to `html` along with the type changing to `string`. See PR comment here: WordPress/gutenberg#10439 (comment)
ryanwelcher
approved these changes
Oct 21, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added schema defintion to each file, this allows validation and auto complete in supported browers.
Required fixing the textDomain => textdomain
Highlighted an issue with
source: childrenstill being used when it should be switched tohtml.See comment here: WordPress/gutenberg#10439 (comment)