Get floated images working as expected. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. This is required for them to take up the avaialble space when floated.
Set content width to 636 instead of 740 (to align with changes in WordPress#49) Add margins to figcaptions in floated images so they match the margins of the images themselves.
Not just resized ones. Turns out they need to be 100% wide for Chrome to display properly.
|
Confirmed, this is working! Thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, floated images are broken:
This PR fixes that:
There is one caveat though — The theme imposes a 50% width on all floated images, as per @jasmussen's commits in #40. Unfortunately, this means that we ignore the custom dimensions of all images. :/
We can theoretically remove this and everything works mostly fine. The only remaining bug is the image captions. I can't find a graceful way to make those captions mirror the width of the image above them:
@jasmussen (or anyone else), I wonder if you have any suggestions for how we should handle this?