Combobox Control: Do not clear values when focusing the textbox

WordPress · Sep 12, 2024 · 0423a7e · 0423a7e
1 parent e9d31c2
commit 0423a7e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/packages/components/src/combobox-control/index.tsx b/packages/components/src/combobox-control/index.tsx
@@ -241,9 +241,6 @@ function ComboboxControl( props: ComboboxControlProps ) {
 		if ( expandOnFocus ) {
 			setIsExpanded( true );
 		}
-
-		onFilterValueChange( '' );
-		setInputValue( '' );
 	};
 
 	const onClick = () => {

diff --git a/packages/components/src/combobox-control/test/index.tsx b/packages/components/src/combobox-control/test/index.tsx
@@ -188,6 +188,26 @@ describe.each( [
 		expect( input ).toHaveValue( targetOption.label );
 	} );
 
+	it( 'calls onFilterValueChange whenever the textbox changes', async () => {
+		const user = userEvent.setup();
+		const onChangeSpy = jest.fn();
+		render(
+			<Component
+				options={ timezones }
+				label={ defaultLabelText }
+				onFilterValueChange={ onChangeSpy }
+			/>
+		);
+		const input = getInput( defaultLabelText );
+
+		await user.click( input );
+		expect( onChangeSpy ).not.toHaveBeenCalled();
+
+		await user.type( input, 'a' );
+		expect( onChangeSpy ).toHaveBeenCalledTimes( 1 );
+		expect( onChangeSpy ).toHaveBeenCalledWith( 'a' );
+	} );
+
 	it( 'should select the correct option from a search', async () => {
 		const user = await userEvent.setup();
 		const targetOption = timezones[ 13 ];