Quote Block: Fixing focus transfer between citation and content

WordPress · Feb 16, 2018 · 04532b4 · 04532b4
1 parent 2b9bc80
commit 04532b4
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/blocks/library/pullquote/editor.scss b/blocks/library/pullquote/editor.scss
@@ -11,6 +11,10 @@
 }
 
 .wp-block-pullquote {
+	cite {
+		display: block;
+	}
+
 	cite .blocks-rich-text__tinymce[data-is-empty="true"]:before {
 		font-size: 14px;
 		font-family: $default-font;

diff --git a/blocks/library/quote/editor.scss b/blocks/library/quote/editor.scss
@@ -1,5 +1,9 @@
 .wp-block-quote {
 	margin: 0;
+
+	cite {
+		display: block;
+	}
 }
 
 .wp-block-quote:not(.is-large) {

diff --git a/blocks/library/quote/index.js b/blocks/library/quote/index.js
@@ -158,7 +158,9 @@ export const settings = {
 	} )( ( { attributes, setAttributes, isSelected, mergeBlocks, onReplace, className, editable, setState } ) => {
 		const { align, value, citation, style } = attributes;
 		const containerClassname = classnames( className, style === 2 ? 'is-large' : '' );
-		const onSetActiveEditable = ( newEditable ) => () => setState( { editable: newEditable } );
+		const onSetActiveEditable = ( newEditable ) => () => {
+			setState( { editable: newEditable } );
+		};
 
 		return [
 			isSelected && (

diff --git a/blocks/rich-text/index.js b/blocks/rich-text/index.js
@@ -740,7 +740,9 @@ export class RichText extends Component {
 			!! this.editor &&
 			this.props.tagName === prevProps.tagName &&
 			this.props.value !== prevProps.value &&
-			this.props.value !== this.savedContent
+			this.props.value !== this.savedContent &&
+			! isEqual( this.props.value, prevProps.value ) &&
+			! isEqual( this.props.value, this.savedContent )
 		) {
 			this.updateContent();
 		}