Fix: Gradient picker bug onToggle (#21732)

WordPress · Apr 21, 2020 · 04cdf34 · 04cdf34
1 parent 0f1f5e7
commit 04cdf34
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/components/src/custom-gradient-picker/control-points.js b/packages/components/src/custom-gradient-picker/control-points.js
@@ -214,7 +214,11 @@ export default function ControlPoints( {
 								) {
 									return;
 								}
-								onStartControlPointChange();
+								if ( isOpen ) {
+									onStopControlPointChange();
+								} else {
+									onStartControlPointChange();
+								}
 								onToggle();
 							} }
 							onMouseDown={ () => {

diff --git a/packages/components/src/custom-gradient-picker/custom-gradient-bar.js b/packages/components/src/custom-gradient-picker/custom-gradient-bar.js
@@ -51,8 +51,12 @@ function InsertPoint( {
 				<Button
 					aria-expanded={ isOpen }
 					onClick={ () => {
-						setAlreadyInsertedPoint( false );
-						onOpenInserter();
+						if ( isOpen ) {
+							onCloseInserter();
+						} else {
+							setAlreadyInsertedPoint( false );
+							onOpenInserter();
+						}
 						onToggle();
 					} }
 					className="components-custom-gradient-picker__insert-point"