[Components - Popover]: Fix regression of inbetween inserter in site …

…editor (#42329) * [Components - Popover]: Fix regression of inbetween inserter in site editor * add changelog entry * update readme * update changelog
WordPress · Jul 12, 2022 · 1049ef3 · 1049ef3
1 parent 25cf5df
commit 1049ef3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md
@@ -6,8 +6,9 @@
 
 -   `BoxControl`: Change ARIA role from `region` to `group` to avoid unwanted ARIA landmark regions ([#42094](https://github.com/WordPress/gutenberg/pull/42094)).
 -   `FocalPointPicker`, `FormTokenField`, `ResizableBox`: Fixed SSR breakage ([#42248](https://github.com/WordPress/gutenberg/pull/42248)).
--   `Popover`: pass missing anchor ref to the `getAnchorRect` callback prop. ([#42076](https://github.com/WordPress/gutenberg/pull/42076))
 -   `ComboboxControl`: use custom prefix when generating the instanceId ([#42134](https://github.com/WordPress/gutenberg/pull/42134).
+-   `Popover`: pass missing anchor ref to the `getAnchorRect` callback prop. ([#42076](https://github.com/WordPress/gutenberg/pull/42076)).
+-   `Popover`: call `getAnchorRect` callback prop even if `anchorRefFallback` has no value. ([#42329](https://github.com/WordPress/gutenberg/pull/42329)).
 
 ### Internal
 

diff --git a/packages/components/src/popover/README.md b/packages/components/src/popover/README.md
@@ -61,7 +61,7 @@ Set this prop to `false` to disable focus changing entirely. This should only be
 
 ### placement
 
-The direction in which the popover should open relative to its parent node or anchor node. 
+The direction in which the popover should open relative to its parent node or anchor node.
 
 The available base placements are 'top', 'right', 'bottom', 'left'.
 
@@ -137,7 +137,7 @@ A callback function which is used to override the anchor value computation algor
 
 If you need the `DOMRect` object i.e., the position of popover to be calculated on every time, the popover re-renders, then use `getAnchorRect`.
 
-`getAnchorRect` callback function receives a reference to the popover anchor element as a function parameter and it should return a `DOMRect` object.
+`getAnchorRect` callback function receives a reference to the popover anchor element as a function parameter and it should return a `DOMRect` object. Noting that `getAnchorRect` can be called with `null`.
 
 -   Type: `Function`
 -   Required: No
diff --git a/packages/components/src/popover/index.js b/packages/components/src/popover/index.js
@@ -148,7 +148,7 @@ const Popover = (
 			return anchorRef.ownerDocument;
 		} else if ( anchorRect && anchorRect?.ownerDocument ) {
 			return anchorRect.ownerDocument;
-		} else if ( getAnchorRect && anchorRefFallback.current ) {
+		} else if ( getAnchorRect ) {
 			return (
 				getAnchorRect( anchorRefFallback.current )?.ownerDocument ??
 				document
@@ -275,7 +275,7 @@ const Popover = (
 					return anchorRect;
 				},
 			};
-		} else if ( getAnchorRect && anchorRefFallback.current ) {
+		} else if ( getAnchorRect ) {
 			usedRef = {
 				getBoundingClientRect() {
 					const rect = getAnchorRect( anchorRefFallback.current );